-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14925] Add interfaces for ReadCondition #2778
Conversation
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima Please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According with DDS 1.4 2.2.2.5.3.10 the following DataReader
methods should fail if the given condition is not attach to the reader. Thus, they cannot neither default nor accept a nullptr
:
- read_w_condition()
- take_w_condition()
- read_next_instance_w_condition()
- take_next_instance_w_condition()
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiprosima Please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the reasonable defaults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's a pity to be forced to remove all default argument values to keep the standard parameter order 🙄
@richiprosima Please test mac |
Description
This PR adds the necessary changes to the public API in order to support ReadCondition.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist